lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/9] srp: use the new CQ API
    From
    Date
    On 11/13/2015 05:46 AM, Christoph Hellwig wrote:
    > +static void srp_inv_rkey_done(struct ib_cq *cq, struct ib_wc *wc)
    > +{
    > + srp_handle_qp_err(cq, wc, "INV RKEY");
    > +}
    >
    > [ ... ]
    >
    > +static void srp_reg_mr_done(struct ib_cq *cq, struct ib_wc *wc)
    > +{
    > + srp_handle_qp_err(cq, wc, "FAST REG");
    > +}

    How about using names like srp_inv_rkey_err() and srp_reg_mr_err() to
    make clear that these completion functions are only called if an error
    occurred ?

    Bart.


    \
     
     \ /
      Last update: 2015-11-17 21:21    [W:5.261 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site