Messages in this thread | | | Date | Tue, 17 Nov 2015 19:05:32 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 3/8] stop_machine: make cpu_stop_queue_work() and stop_one_cpu_nowait() return bool |
| |
On Tue, Nov 17, 2015 at 06:05:23PM +0100, Oleg Nesterov wrote: > On 11/15, Oleg Nesterov wrote: > > > > --- a/include/linux/stop_machine.h > > +++ b/include/linux/stop_machine.h > > @@ -29,7 +29,7 @@ struct cpu_stop_work { > > > > int stop_one_cpu(unsigned int cpu, cpu_stop_fn_t fn, void *arg); > > int stop_two_cpus(unsigned int cpu1, unsigned int cpu2, cpu_stop_fn_t fn, void *arg); > > -void stop_one_cpu_nowait(unsigned int cpu, cpu_stop_fn_t fn, void *arg, > > +bool stop_one_cpu_nowait(unsigned int cpu, cpu_stop_fn_t fn, void *arg, > > struct cpu_stop_work *work_buf); > > Peter, sorry!!! > > I forgot to update the !CONFIG_SMP version of stop_one_cpu_nowait(). Please > see V2 below.
No problem, updated the patch.
| |