lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [BUG] checkpatch: false positive for commits with quote characters
From
Date
On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> Hi,
>
> What is the Blessed (TM) style for referencing commits that have quote
> characters in their subject line? e.g., this commit:
>
> commit 43163022927b6e7d202a7e6f939c3f392465494d
> Author: Brian Norris <computersforpeace@gmail.com>
> Date: Tue May 19 14:38:22 2015 -0700
>
> mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
>
> Checkpatch reports false positive errors like this:
>
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("")'

Hi Brian.

What version of checkpatch are you using?

Using linux-next:

$ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -
total: 0 errors, 0 warnings, 0 checks, 53 lines checked

Your patch has no obvious style problems and is ready for submission.



\
 
 \ /
  Last update: 2015-11-17 19:21    [W:0.055 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site