lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 1/3] crypto-ixp4xx: Delete unnecessary checks before the function call "dma_pool_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 15 Nov 2015 16:51:21 +0100

    The dma_pool_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/crypto/ixp4xx_crypto.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
    index 8f27903..e52496a 100644
    --- a/drivers/crypto/ixp4xx_crypto.c
    +++ b/drivers/crypto/ixp4xx_crypto.c
    @@ -510,10 +510,8 @@ npe_error:
    printk(KERN_ERR "%s not responding\n", npe_name(npe_c));
    ret = -EIO;
    err:
    - if (ctx_pool)
    - dma_pool_destroy(ctx_pool);
    - if (buffer_pool)
    - dma_pool_destroy(buffer_pool);
    + dma_pool_destroy(ctx_pool);
    + dma_pool_destroy(buffer_pool);
    npe_release(npe_c);
    return ret;
    }
    --
    2.6.2

    \
     
     \ /
      Last update: 2015-11-17 17:01    [W:4.207 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site