Messages in this thread | | | Date | Tue, 17 Nov 2015 07:44:31 -0700 | From | Jonathan Corbet <> | Subject | Re: [PATCH v2 2/4] scripts/kernel-doc: Replacing highlights hash by an array |
| |
On Tue, 17 Nov 2015 08:40:46 -0200 Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote:
> The above causes some versions of perl to fail, as keys expect a > hash argument: > > Execution of .//scripts/kernel-doc aborted due to compilation errors. > Type of arg 1 to keys must be hash (not private array) at .//scripts/kernel-doc line 2714, near "@highlights) " > > This is happening at linuxtv.org server, with runs perl version 5.10.1.
OK, that's not good. But I'm not quite sure what to do about it.
Perl 5.10.1 is a little over six years old. Nobody else has complained (yet) about this problem. So it might be best to "fix" this with a minimum version added to the Changes file.
Or maybe we need to revert the patch.
So I'm far from a Perl expert, so I have no clue what the minimum version would be if we were to say "5.10.1 is too old." I don't suppose anybody out there knows?
Thanks,
jon
| |