Messages in this thread | | | Date | Tue, 17 Nov 2015 15:02:20 +0100 | Subject | Re: [PATCH] pinctrl: imx1-core: add missing of_node_put | From | Linus Walleij <> |
| |
On Sun, Nov 15, 2015 at 5:04 AM, Vaishali Thakkar <vthakkar1994@gmail.com> wrote:
> for_each_child_of_node performs an of_node_get on each iteration, > so of_node_put is required on break out of the loop. > > This is done using Coccinelle. And semantic patch used for this is > as follows: > > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Patch applied for fixes, thanks!
Yours, Linus Walleij
| |