Messages in this thread Patch in this message | | | Subject | [PATCH 1/3] ste_dma40: Delete an unnecessary check before the function call "kmem_cache_destroy" | From | SF Markus Elfring <> | Date | Mon, 16 Nov 2015 22:23:01 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 16 Nov 2015 20:26:27 +0100
The kmem_cache_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/dma/ste_dma40.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index dd3e7ba..9132ae0 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3694,8 +3694,7 @@ static int __init d40_probe(struct platform_device *pdev) failure: if (base) { - if (base->desc_slab) - kmem_cache_destroy(base->desc_slab); + kmem_cache_destroy(base->desc_slab); if (base->virtbase) iounmap(base->virtbase); -- 2.6.2
| |