Messages in this thread Patch in this message | | | Subject | [PATCH] net: dsa: Delete an unnecessary check before the function call "put_device" | From | SF Markus Elfring <> | Date | Sat, 14 Nov 2015 18:12:44 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 14 Nov 2015 17:58:00 +0100
The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- net/dsa/dsa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 1eba07f..045d776 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -671,8 +671,7 @@ static void dsa_of_free_platform_data(struct dsa_platform_data *pd) kfree(pd->chip[i].rtable); /* Drop our reference to the MDIO bus device */ - if (pd->chip[i].host_dev) - put_device(pd->chip[i].host_dev); + put_device(pd->chip[i].host_dev); } kfree(pd->chip); } -- 2.6.2
| |