lkml.org 
[lkml]   [2015]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 04/60] regmap: debugfs: Don't bother actually printing when calculating max length
    3.2.73-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mark Brown <broonie@kernel.org>

    commit 176fc2d5770a0990eebff903ba680d2edd32e718 upstream.

    The in kernel snprintf() will conveniently return the actual length of
    the printed string even if not given an output beffer at all so just do
    that rather than relying on the user to pass in a suitable buffer,
    ensuring that we don't need to worry if the buffer was truncated due to
    the size of the buffer passed in.

    Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/base/regmap/regmap-debugfs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/base/regmap/regmap-debugfs.c
    +++ b/drivers/base/regmap/regmap-debugfs.c
    @@ -23,8 +23,7 @@ static struct dentry *regmap_debugfs_roo
    /* Calculate the length of a fixed format */
    static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
    {
    - snprintf(buf, buf_size, "%x", max_val);
    - return strlen(buf);
    + return snprintf(NULL, 0, "%x", max_val);
    }

    static int regmap_open_file(struct inode *inode, struct file *file)


    \
     
     \ /
      Last update: 2015-11-15 03:41    [W:4.543 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site