lkml.org 
[lkml]   [2015]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment
On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote:
> Used double equal sign instead of equal to sign in the if condition
> to remove the error detected by checkpatch.pl.
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/staging/drivers/staging/most/aim-cdev/cdev.c | 2 +-

something wrong with your tree. This path doesnot exist.

But in any case, i think the patch is wrong. wait_event_interruptible()
is executed when most_get_mbo() returns NULL. so if you do
mbo == most_get_mbo() it will immediately come out of sleep as the
condition is true. I think here the intention was to sleep as long as
most_get_mbo() returns NULL. And when it returns a valid pointer it is
saved in mbo variable so that it can be used later in copy_from_user().

regards
sudip


\
 
 \ /
  Last update: 2015-11-14 08:21    [W:0.041 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site