lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/mm: fix regression with huge pages on PAE

* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> > But, what problems do you expect with having a wider mask than its primary usage?
> > If it's used for 32-bit values it will be truncated down safely. (But I have not
> > tested it, so I might be missing some complication.)
>
> Yeah, I basically worry about non realized side effect.

Such a worry is prudent, the best way would be to double check a disassembly of a
before/after vmlinux and see in which functions they differ and why.

We might have similar bugs elsewhere - silently fixed by such a change.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-11-12 10:21    [W:0.114 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site