Messages in this thread | | | Date | Thu, 12 Nov 2015 20:05:25 +0100 | From | Matias Bjørling <> | Subject | Re: [PATCH] lightnvm: change max_phys_sect to ushort |
| |
On 11/12/2015 08:02 PM, Linus Torvalds wrote: > On Thu, Nov 12, 2015 at 10:57 AM, Matias Bjørling <m@bjorling.me> wrote: >> >> Grah, I need to be more careful. I sent the wrong patch after I had fixed it >> to unsigned short. > > Actually, I think "unsigned int" was better. > > You're not saving any space with "unsigned short" (the size of the > structure will be rounded up to the alignment of it anyway), and we > should generally strive to avoid 16-bit accesses unless there is some > real reason for them, because they are often slower than either "char" > or "int". Several architectures have weak support for 16-bit accesses > (eg alpha), and even on x86 you end up having operand size overrides > etc. >
Thanks
> So unless there is a clear *reason* to use "short" - just don't. > > Linus >
| |