lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
From
Date
On 11/11/15 15:54, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-11-12 19:21    [W:0.186 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site