lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] sched/rt: hide push_irq_work_func declaration
    Date
    On Thursday 12 November 2015 09:47:39 Steven Rostedt wrote:
    > > -#ifdef CONFIG_SMP
    > > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI)
    >
    > Why IS_ENABLED() and not defined()?
    >
    > #if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI)
    >
    > I thought IS_ENABLED() is used for C code, like:
    >
    > if (IS_ENABLED(CONFIG_SMP)) {
    > [...]
    > }

    "#if IS_ENABLED(CONFIG_foo)" has another property, which is
    to evaluate to true when Kconfig has set the symbol to "=m".
    Obviously that cannot happen for CONFIG_SMP, but some
    maintainers prefer using IS_ENABLED() consistently for all
    config symbols.

    I don't care much either way, and it's easily changed if
    we still want the patch and you prefer a plain #if defined().

    Arnd


    \
     
     \ /
      Last update: 2015-11-12 16:21    [W:2.632 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site