Messages in this thread | | | Date | Thu, 12 Nov 2015 11:23:41 +0100 | Subject | Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() | From | Geert Uytterhoeven <> |
| |
Hi David,
On Thu, Nov 12, 2015 at 11:15 AM, David Howells <dhowells@redhat.com> wrote: > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> - int ret; >> + int ret = 0; > > This isn't quite the right solution. The uninitialised error path needs to > set -ENOBUFS.
That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the page immediately beyond the EOF marker") does, and is also in its commit description:
Whilst we're at it, change the triggered assertion in CacheFiles to just return -ENOBUFS instead.
"ret" is used only to print the original error in a debug message.
> Unfortunately, my compiler doesn't show a warning:-/
Need old gcc (4.1.2 ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |