Messages in this thread | | | Date | Wed, 11 Nov 2015 13:56:48 +0100 | From | Hannes Reinecke <> | Subject | Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable |
| |
On 11/11/2015 01:00 PM, Sreekanth Reddy wrote: > From: Sreekanth Reddy <sreekanth.reddy@avagotech.com> > > 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely > identify each individual generation driver functionality at > runtime. > > 2. Declared global variable 'driver_name' and used > this variable while reserving PCI regions and while > allocating the IRQ's. > > Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com> > --- > drivers/scsi/mpt2sas/mpt2sas_module.c | 1 + > drivers/scsi/mpt3sas/mpt3sas_base.c | 8 +++---- > drivers/scsi/mpt3sas/mpt3sas_base.h | 3 +++ > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 18 +++++++++++++--- > drivers/scsi/mpt3sas/mpt3sas_module.c | 1 + > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 39 ++++++++++++++++++++++++++++++++++- > 6 files changed, 62 insertions(+), 8 deletions(-) > I'd rather shorten that to 'hba_mpi_version'.
Other than that it's okay.
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
| |