Messages in this thread | | | Date | Wed, 11 Nov 2015 12:01:34 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/3] x86, ras: Extend machine check recovery code to annotated ring0 areas |
| |
On Tue, Nov 10, 2015 at 02:11:35PM -0800, Luck, Tony wrote: > That would be tidier ... the inside of the "if" has been gradually growing > with added recovery paths. I had to fold the mce_panic() line to shut > checkpatch up.
Bah, I don't take checkpatch seriously anymore. In that case, you could've left the line stick out, for all I know. Our monitors can do more pixels since the 1980s I believe. :)
> But I'm not really sure what tolerant==3 people really want here. By skipping > the recovery code they doom themselves to hitting the machine check again.
Looks like a loop to me, fun.
I guess the user application should be aware of BUS_MCEERR_AR and not attempt the same access to not cause a loop with tolerant==3. Alternatively, we can still kill it to prevent the looping...
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |