lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] wait: add comment before waitqueue_active noting memory barrier is required
Peter Zijlstra <peterz@infradead.org> wrote:
>
>> >> Second, on the waiting thread side, the CPU can reorder the load of
>> >> CONDITION to occur during add_wait_queue active, before the entry is
>> >> added to the wait queue.
>> >> wake_up thread waiting thread
>> >> (reordered)
>> >> ------------------------------------------------------------------------
>> >> spin_lock_irqsave(...) <add_wait_queue>
>> >> if (CONDITION)
>> >> CONDITION = 1;
>> >> if (waitqueue_active(wq))
>> > wake_up();
>> >> __add_wait_queue(...) <add_wait_queue>
>> >> spin_unlock_irqrestore(...) <add_wait_queue>
>> >> wait_woken(&wait, ...);
>> >> ------------------------------------------------------------------------
>> >
>> > This isn't actually a problem IIRC, because wait_woken() will test
>> > WQ_FLAG_WOKEN and not actually sleep.
>>
>> In the above figure, waitqueue_active(wq) will return 0 (queue is
>> inactive) and skip the whole wake_up() call, because __add_wait_queue()
>> hasn't been called yet. This actually does occur using a reproducer.
>
> Duh, indeed.

BTW, the networking folks found this years ago and even added
helpers to deal with this. See for example wq_has_sleeper in
include/net/sock.h. It would be good if we can move some of
those helpers into wait.h instead.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2015-11-11 11:01    [W:0.188 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site