Messages in this thread | | | Date | Tue, 10 Nov 2015 19:11:12 -0800 | Subject | Re: [PATCH] arm64: bpf: fix JIT stack setup | From | Z Lim <> |
| |
On Tue, Nov 10, 2015 at 11:46 AM, Shi, Yang <yang.shi@linaro.org> wrote: > On 11/9/2015 12:00 PM, Z Lim wrote: >> >> How about splitting this into two patches? One for the BPF-related >> bug, and another for A64 FP-handling. > > I'm not sure if this is a good approach or not. IMHO, they are kind of > atomic. Without A64 FP-handling, that fix looks incomplete and introduces > another problem (stack backtrace). >
The first, even on its own, doesn't make things worse, only better. The second, which we agree needs to be fixed also, addresses a different issue.
Either way, please also note that these patches fix the original implementation. We do want -stable to pick these up.
Suggestions for the diagram: - As an enhancement, would you mind showing the A64_FP also? - Please revisit "+64:"
| |