Messages in this thread | | | Subject | Re: [PATCH] of: Print rather than WARN'ing when overlap check fails | From | Michael Ellerman <> | Date | Wed, 11 Nov 2015 08:47:03 +1100 |
| |
On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote:
> From: Michael Ellerman
> > Sent: 10 November 2015 05:09 > > __rmem_check_for_overlap() is called very early in boot, and on some > > powerpc systems it's not safe to call WARN that early in boot. > > > > If the overlap check fails the system will oops instead of printing a > > warning. Furthermore because it's so early in boot the console is not up > > and the user doesn't see the oops, they just get a dead system. > > Wouldn't it be better to add the required checks to WARN()?
Yes obviously it would. But that's less simple than it sounds. I'm working on it.
cheers
| |