lkml.org 
[lkml]   [2015]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/6] slab: add SLAB_ACCOUNT flag
    On Tue, Nov 10, 2015 at 09:34:05PM +0300, Vladimir Davydov wrote:
    > Currently, if we want to account all objects of a particular kmem cache,
    > we have to pass __GFP_ACCOUNT to each kmem_cache_alloc call, which is
    > inconvenient. This patch introduces SLAB_ACCOUNT flag which if passed to
    > kmem_cache_create will force accounting for every allocation from this
    > cache even if __GFP_ACCOUNT is not passed.
    >
    > This patch does not make any of the existing caches use this flag - it
    > will be done later in the series.
    >
    > Note, a cache with SLAB_ACCOUNT cannot be merged with a cache w/o
    > SLAB_ACCOUNT, i.e. using this flag will probably reduce the number of
    > merged slabs even if kmem accounting is not used (only compiled in).

    Am I correct in thinking that we should eventually be able to removed
    __GFP_ACCOUNT and that only caches explicitly marked with SLAB_ACCOUNT
    would need to be handled by kmemcg?

    Thanks a lot for doing this!

    --
    tejun


    \
     
     \ /
      Last update: 2015-11-10 20:01    [W:4.336 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site