Messages in this thread | | | From | Michal Nazarewicz <> | Subject | Re: [PATCH 1/3] mm/page_isolation: return last tested pfn rather than failure indicator | Date | Tue, 10 Nov 2015 17:05:12 +0100 |
| |
On Mon, Nov 09 2015, Joonsoo Kim wrote: > This is preparation step to report test failed pfn in new tracepoint > to analyze cma allocation failure problem. There is no functional change > in this patch. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> --- > mm/page_isolation.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > @@ -266,10 +264,11 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > /* Check all pages are free or marked as ISOLATED */ > zone = page_zone(page); > spin_lock_irqsave(&zone->lock, flags); > - ret = __test_page_isolated_in_pageblock(start_pfn, end_pfn, > + pfn = __test_page_isolated_in_pageblock(start_pfn, end_pfn, > skip_hwpoisoned_pages); > spin_unlock_irqrestore(&zone->lock, flags); > - return ret ? 0 : -EBUSY; > + > + return (pfn < end_pfn) ? -EBUSY : 0;
Parens aren’t necessary. No strong feelings.
> } > > struct page *alloc_migrate_target(struct page *page, unsigned long private,
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o) ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>-----ooO--(_)--Ooo--
| |