lkml.org 
[lkml]   [2015]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: arm/arm64: GICv2 driver does not have irq_disable implemented
    On Fri, Oct 9, 2015 at 10:52 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
    > On Fri, 9 Oct 2015, Duc Dang wrote:
    >> Hi Thomas, Marc, Jason and All,
    >>
    >> In APM ARM64 X-Gene Enet controller driver, we use disable_irq_nosync to
    >> disable interrupt before calling __napi_schedule to schedule packet handler
    >> to process the Tx/Rx packets.
    >
    > Which is wrong to begin with. Disable the interrupt at the device
    > level not at the interrupt line level.
    >
    Hi Thomas,

    We could not disable the interrupt at Enet controller level due to the
    controller limitation. As you said, using disable_irq_nosync is wrong
    but it looks like that the only option that we have.

    Do you have any suggestion about different approach that we could try?

    > Thanks,
    >
    > tglx

    Regards,
    Duc Dang.


    \
     
     \ /
      Last update: 2015-10-09 23:01    [W:4.253 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site