Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH 0/6] staging: comedi: fix some minor issues with file poll op | Date | Fri, 9 Oct 2015 17:27:33 +0000 |
| |
On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote: > A few changes for the "poll" file operation to avoid poll-waiting on the > same subdevice for both read and write (patch 1), avoid allocating write > buffer space unnecessarily and possibly inappropriately (patch 4), > consider whether any active commands belong to the current file object > (patch 5), and avoid using the main mutex (for performance reasons) > (patch 6). > > 1) staging: comedi: don't poll_wait on same subdevice twice > 2) staging: comedi: rename comedi_buf_write_n_available > 3) staging: comedi: add new comedi_buf_write_n_available() > 4) staging: comedi: don't allocate buffer space when polling for write > 5) staging: comedi: check command started by file being polled > 6) staging: comedi: don't use mutex when polling file > > drivers/staging/comedi/comedi_buf.c | 19 +++++++++++++------ > drivers/staging/comedi/comedi_fops.c | 17 +++++++++-------- > drivers/staging/comedi/comedi_internal.h | 1 + > 3 files changed, 23 insertions(+), 14 deletions(-)
Thanks!
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
| |