lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0
Date
Ben Hutchings <ben@decadent.org.uk> wrote:

> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -176,6 +176,8 @@ enum pci_dev_flags {
> PCI_DEV_FLAGS_NO_D3 = (__force pci_dev_flags_t) 2,
> /* Provide indication device is assigned by a Virtual Machine Manager */
> PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4,
> + /* Get VPD from function 0 VPD */
> + PCI_DEV_FLAGS_VPD_REF_F0 = (__force pci_dev_flags_t) (1 << 8),
> };
>
> enum pci_irq_reroute_variant {

In this hunk I happened to notice the change in how these values are assigned. Should the new value remain (1 << 8) or should it fall in line with the older implementation and simply be 8? Or should it be 256? It depends on which kind of consistency you prefer for the backport.

--
Mark Rustad, Networking Division, Intel Corporation
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-10-09 02:41    [W:0.329 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site