lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/9] net/inetdevice: bad_mask can be boolean
    Date
    This patch makes bad_mask return bool due to this particular function
    only using either one or zero as its return value.

    No functional change.

    Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
    ---
    include/linux/inetdevice.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h
    index 3b0999e..ee971f3 100644
    --- a/include/linux/inetdevice.h
    +++ b/include/linux/inetdevice.h
    @@ -180,15 +180,15 @@ static __inline__ bool inet_ifa_match(__be32 addr, struct in_ifaddr *ifa)
    * Check if a mask is acceptable.
    */

    -static __inline__ int bad_mask(__be32 mask, __be32 addr)
    +static __inline__ bool bad_mask(__be32 mask, __be32 addr)
    {
    __u32 hmask;
    if (addr & (mask = ~mask))
    - return 1;
    + return true;
    hmask = ntohl(mask);
    if (hmask & (hmask+1))
    - return 1;
    - return 0;
    + return true;
    + return false;
    }

    #define for_primary_ifa(in_dev) { struct in_ifaddr *ifa; \
    --
    1.9.1



    \
     
     \ /
      Last update: 2015-10-08 16:01    [W:3.266 / U:0.984 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site