Messages in this thread | | | Date | Thu, 8 Oct 2015 10:51:33 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match |
| |
* Prarit Bhargava <prarit@redhat.com> wrote:
> re-ping on this. Just making sure this wasn't dropped on the floor.
So I didn't apply it back when I saw your patch because I didn't see where you addressed/analyzed the second paragraph of hpa's review:
"The downside with set is that it only sets a single byte, the upside is that it always outputs 0 or 1, and apparently if the output variable is your bool gcc can use that for optimization."
That's a valid concern and should be addressed.
Thanks,
Ingo
| |