lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

* Prarit Bhargava <prarit@redhat.com> wrote:

> re-ping on this. Just making sure this wasn't dropped on the floor.

So I didn't apply it back when I saw your patch because I didn't see where you
addressed/analyzed the second paragraph of hpa's review:

"The downside with set is that it only sets a single byte, the upside is that it
always outputs 0 or 1, and apparently if the output variable is your bool gcc
can use that for optimization."

That's a valid concern and should be addressed.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-10-08 11:21    [W:0.066 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site