lkml.org 
[lkml]   [2015]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable


On Wed, 7 Oct 2015, Maurizio Lombardi wrote:

> Hi,
>
> On 10/07/2015 03:11 PM, Arnd Bergmann wrote:
>> - memset(&npiv_tbl, 0, sizeof(npiv_tbl));
>> - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl))
>> + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL);
>> + if (!npiv_tbl)
>> goto done;
>>
>
> If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
>

The enablement of the fcoe interface can still proceed if this particular
allocation fails so returning 0 would be appropriate here.

This patch looks good to me.

>
> Regards,
> Maurizio Lombardi
>


\
 
 \ /
  Last update: 2015-10-07 21:01    [W:0.518 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site