lkml.org 
[lkml]   [2015]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support
    From
    Date
    On Tue, 2015-10-06 at 22:32 +0100, Stephen Hemminger wrote:
    > On Tue, 06 Oct 2015 12:51:20 -0600
    > Alex Williamson <alex.williamson@redhat.com> wrote:
    >
    > > Of course this is entirely unsafe and this no-iommu driver should taint
    > > the kernel, but it at least standardizes on one userspace API and you're
    > > already doing completely unsafe things with uio. vfio should be
    > > enlightened at least to the point that it allows only privileged users
    > > access to devices under such a (lack of) iommu
    >
    > I agree with the design, but not with the taint argument.
    > (Unless you want to taint any and all use of UIO drivers which can
    > already do this).

    Yes, actually, if the bus master bit gets enabled all bets are off. I
    don't see how that leaves a supportable kernel, so we might as well
    taint it. Isn't this exactly why we taint for proprietary drivers, we
    have no idea what it has mucked with in kernel space. This just moves
    the proprietary driver out to userspace without an iommu to protect the
    host. Thanks,

    Alex



    \
     
     \ /
      Last update: 2015-10-07 00:01    [W:3.676 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site