| From | Andy Lutomirski <> | Date | Tue, 6 Oct 2015 11:21:41 -0700 | Subject | Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure |
| |
On Tue, Oct 6, 2015 at 1:23 AM, Ingo Molnar <mingo@kernel.org> wrote: > > * Andy Lutomirski <luto@kernel.org> wrote: > >> Commit 131484c8da97 ("x86/debug: Remove perpetually broken, >> unmaintainable dwarf annotations") removed all the manual DWARF >> annotations outside the vDSO. It also removed the macros we used >> for the manual annotations. >> >> Re-add the macros so that we can clean up the vDSO annotations. >> >> Signed-off-by: Andy Lutomirski <luto@kernel.org> >> --- >> arch/x86/Makefile | 10 ++- >> arch/x86/include/asm/dwarf2.h | 170 ++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 178 insertions(+), 2 deletions(-) >> create mode 100644 arch/x86/include/asm/dwarf2.h > > Please don't add all this gunk back in! > > AFAICS the later patches use just a very small subset - add only the minimal > subset absolutely needed.
OK, I'll strip out the push, movq, etc stuff for v3. I'll leave all of the CFI_XYZ macros, even the unused one, because that's only a couple of lines of code and they all have very simple and obvious meanings (or as simple as the underlying directives, anyway).
--Andy
|