| Subject | Re: [PATCH v2 15/25] powerpc/8xx: move 8xx SPRN defines into reg_8xx.h and add some missing ones | From | Christophe Leroy <> | Date | Tue, 6 Oct 2015 16:35:45 +0200 |
| |
Le 29/09/2015 02:03, Scott Wood a écrit : > On Tue, Sep 22, 2015 at 06:50:58PM +0200, Christophe Leroy wrote: >> Move 8xx SPRN defines into reg_8xx.h and add some missing ones >> >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> >> --- >> No change in v2 > Why are they being moved? Why are they being separated from the bit > definitions? > > It was to keep asm/reg_8xx.h self sufficient for the following patch.
Also because including asm/mmu-8xx.h creates circular inclusion issue (mmu-8xx.h needs page.h which includes page-32.h, page-32.h includes cache.h, cache.h include reg.h which includes reg_8xx). The circle starts with an inclusion of asm/cache.h by linux/cache.h, himself included by linux/printk.h, and I end up with 'implicit declaration' issues.
How can I fix that ?
Christophe
|