Messages in this thread | | | Date | Tue, 6 Oct 2015 11:29:34 +0100 | Subject | Re: [PATCH v2 21/22] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs | From | Steve Capper <> |
| |
On 6 October 2015 at 11:25, Mark Rutland <mark.rutland@arm.com> wrote: > On Tue, Oct 06, 2015 at 11:18:42AM +0100, Steve Capper wrote: >> On 6 October 2015 at 10:09, Russell King - ARM Linux >> <linux@arm.linux.org.uk> wrote: >> > On Mon, Oct 05, 2015 at 06:02:10PM +0100, Suzuki K. Poulose wrote: >> >> +static int __init cpuinfo_regs_init(void) >> >> +{ >> >> + int cpu, ret; >> >> + >> >> + for_each_present_cpu(cpu) { >> >> + struct device *dev = get_cpu_device(cpu); >> >> + >> >> + if (!dev) >> >> + return -1; >> > >> > NAK. Go figure out why, I'm too lazy to tell you. >> >> I will correct the return code to be -ENODEV. >> Was that the reasoning behind the NAK? > > I suspect the half-initialised sysfs groups also have something to do > with it...
Okay, cheers Mark, I see what you mean.
> > Mark. > >> >> > >> >> + >> >> + ret = sysfs_create_group(&dev->kobj, &cpuregs_attr_group); >> >> + if (ret) >> >> + return ret; >> >> + } >> >> + >> >> + return 0; >> >> +} >> >> + >> >> +device_initcall(cpuinfo_regs_init); >> >> -- >> >> 1.7.9.5 >>
| |