Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 6 Oct 2015 17:56:28 +0900 | Subject | Re: [RFC/PATCH 03/38] perf tools: Move auxtrace_mmap field to struct perf_evlist |
| |
On Sat, Oct 3, 2015 at 3:45 AM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Em Fri, Oct 02, 2015 at 02:18:44PM +0900, Namhyung Kim escreveu: >> Since it's gonna share struct mmap with dummy tracking evsel to track >> meta events only, let's move auxtrace out of struct perf_mmap. > > Is this moving around _strictly_ needed?
In the later patch, I added another perf_mmap instance for dummy tracking events. So keeping auxtrace_mmap in the perf_mmap is a duplication. It's not strictly needed but will waste some memory.
Thanks, Namhyung
| |