lkml.org 
[lkml]   [2015]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 06/10] dmaengine: add API for getting dma controller's quirk
    On Mon, Sep 14, 2015 at 07:48:59AM +0800, Shawn Lin wrote:
    > Add dmaengine_get_quirks API for peripheral devices to query
    > quirks if they need it to make special workaround due to broken
    > dma controller design.
    >
    > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
    > ---
    >
    > Changes in v5: None
    > Changes in v4: None
    > Changes in v3: None
    > Changes in v2: None
    > Changes in v1: None
    >
    > include/linux/dmaengine.h | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
    > index e2f5eb4..5174ca4 100644
    > --- a/include/linux/dmaengine.h
    > +++ b/include/linux/dmaengine.h
    > @@ -704,6 +704,7 @@ struct dma_device {
    >
    > int (*device_config)(struct dma_chan *chan,
    > struct dma_slave_config *config);
    > + int (*device_get_quirks)(struct dma_chan *chan);

    And why do we want to expose this to users? THis doesnt seem right!

    A quirk may exists but should be handled inside the controller driver and do
    appropriate action. You don't tell users or expect them to handle these

    --
    ~Vinod


    \
     
     \ /
      Last update: 2015-10-05 18:01    [W:2.731 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site