Messages in this thread | | | Date | Mon, 5 Oct 2015 03:55:55 -0700 | From | Tony Lindgren <> | Subject | Re: [RFC/PATCH 00/11] arm: omap: counter32k rework |
| |
* Daniel Lezcano <daniel.lezcano@linaro.org> [151001 15:16]: > On 09/30/2015 04:49 PM, Arnd Bergmann wrote: > >On Wednesday 30 September 2015 16:42:21 Arnd Bergmann wrote: > >> > >>TEGRA folks: the tegra_read_persistent_clock() implementation apparently > >>predates the Tegra RTC driver and I wonder if they actually do the > >>right thing in combination. Could it be that the wall time forwards > >>twice as fast as it should during resume when the RTC driver is loaded? > >>Could it be that we can simply remove tegra_read_persistent_clock() > >>and the register_persistent_clock() infrastructure? > >> > > > >I found the 'sleeptime_injected' variable now, which takes care of > >forwarding the clock by the correct amount. > > > >I also found the CLOCK_SOURCE_SUSPEND_NONSTOP flag next to it, which > >should let us use the counter32k driver to provide the correct > >time during suspend without the omap_read_persistent_clock() function. > >We should be able to just delete that code. > > > >If we decide to also delete the tegra_read_persistent_clock() > >function, we can remove the registration too. > > > +1
We could maybe have read_persistent_clock() just check for the CLOCK_SOURCE_SUSPEND_NONSTOP flag?
And we probably should have also has_persistent_clock() or something that also checks for the CLOCK_SOURCE_SUSPEND_NONSTOP.
Regards,
Tony
| |