Messages in this thread | | | Date | Sun, 4 Oct 2015 10:54:01 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' |
| |
On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote: > On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big endian 64-bit systems. There are no such platforms yet, but the > > code needs to be robust for such a case. > > > > Fix that by changing type of 'global_lock' to u32. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Greg, please take this one along with the [2/2] if that one looks good to you.
Thanks, will do.
greg k-h
| |