Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 5 Oct 2015 04:03:52 +0100 | From | Greg KH <> | Subject | Re: [PATCH v3 1/3] uio: add ioctl support |
| |
On Sun, Oct 04, 2015 at 11:43:16PM +0300, Vlad Zolotarov wrote: > Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com> > --- > drivers/uio/uio.c | 15 +++++++++++++++ > include/linux/uio_driver.h | 3 +++ > 2 files changed, 18 insertions(+)
You add an ioctl yet fail to justify _why_ you need/want that ioctl, and you don't document it at all? Come on, you know better than that, no one can take a patch that has no changelog comments at all like this :(
Also, I _REALLY_ don't want to add any ioctls to the UIO interface, so you had better have a really compelling argument as to why this is the _ONLY_ way you can solve this unknown problem by using such a horrid thing...
thanks,
greg k-h
| ![\](/images/icornerr.gif) |