Messages in this thread | | | Date | Sat, 3 Oct 2015 23:27:09 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 5/7] 9p: xattr simplifications |
| |
On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote: > > +/** > + * xattr_full_name - Compute full attribute name from suffix > + *
Missing argument descriptions for a kdoc comment.
> +const char *xattr_full_name(const struct xattr_handler *handler, > + const char *name) > +{ > + size_t prefix_len = strlen(handler->prefix); > + > + /* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */
This either should be a real WARN_ON or go away.
| |