lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/7] 9p: xattr simplifications
On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote:
>
> +/**
> + * xattr_full_name - Compute full attribute name from suffix
> + *

Missing argument descriptions for a kdoc comment.

> +const char *xattr_full_name(const struct xattr_handler *handler,
> + const char *name)
> +{
> + size_t prefix_len = strlen(handler->prefix);
> +
> + /* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */

This either should be a real WARN_ON or go away.


\
 
 \ /
  Last update: 2015-10-04 08:41    [W:0.145 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site