lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
    From
    Date
    On 30.10.2015 15:25, Alim Akhtar wrote:
    > RTC found in s2mps15 is almost same as one found on s2mps13
    > with few differences in RTC_UPDATE register fields, like:
    > 1> Bit[4] and Bit[1] are reversed
    > - On s2mps13
    > WUDR -> bit[4], AUDR -> bit[1]
    > - On s2mps15
    > WUDR -> bit[1], AUDR -> bit[4]
    > 2> In case of s2mps13, for alarm register, need to set both
    > WDUR and ADUR high, whereas for s2mps15 only set AUDR to high.
    > 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used
    > at the same time.
    >
    > This patch add required changes to enable s2mps15 rtc timer.
    >
    > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
    > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
    > ---
    > drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++----
    > include/linux/mfd/samsung/rtc.h | 2 ++
    > 2 files changed, 35 insertions(+), 4 deletions(-)
    >

    The usage of rtc_udr_mask is now a little bit messy and not-consistent
    but this can be fixed in separate patch.

    Current approach is the simplest way to add S2MPS15 and looks correct:

    Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    Best regards,
    Krzysztof



    \
     
     \ /
      Last update: 2015-10-30 09:41    [W:2.537 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site