Messages in this thread | | | Date | Tue, 27 Oct 2015 11:42:15 +0800 | From | "Wangnan (F)" <> | Subject | Re: [net-next PATCHv2] bpf: Output error message to logbuf when loading failure |
| |
On 2015/10/27 11:26, Alexei Starovoitov wrote: > On Mon, Oct 26, 2015 at 07:13:08AM +0000, Wang Nan wrote: >> Many reasons can make bpf_prog_load() return EINVAL. This patch utilizes >> logbuf to deliver the actual reason of the failure. >> >> Without this patch, it is very easy for user to pass an object with >> "version" section not match the kernel version code, and the problem >> is hard to determine from return code (EINVAL). >> >> Signed-off-by: Wang Nan <wangnan0@huawei.com> >> Cc: Alexei Starovoitov <ast@kernel.org> >> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> >> Cc: David S. Miller <davem@davemloft.net> >> Cc: Wu Fengguang <fengguang.wu@intel.com> > NACK > for both implementation and design. OK. Let perf to report error message.
Thank you.
| |