Messages in this thread | | | Date | Mon, 26 Oct 2015 05:30:21 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] GHES: Fix cached error-status |
| |
On Mon, Oct 26, 2015 at 11:20:35AM +0800, Huang, Ying wrote: > In ghes_estatus_caches[], for caches with same contents, the cache with > biggest (newest) cache->time_in should be the first. So if we found one > cache with too small (old) cache->time_in, we can say there are no cache > with same contents and bigger (newer) cache->time_in, so that we can > make decision (break) earlier.
Well, for starters, this should be documented in the code so that people looking at it would not need to scratch their heads over that break statement there.
Thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |