lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] x86/cpufeature: Add CLZERO feature
From
Date
On 10/26/2015 3:22 PM, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 10:12:59AM -0500, Aravind Gopalakrishnan wrote:
>> For large part yes, wrapped code in patch form with commit message etc.
>> And modified comment a little bit.
>>
>> Does that still require his address in "From"?
> Yes, because it sounds like he was the author of the original patch.

Okay, will fix that in V2.

> No, I think you should add that bit to init_scattered_cpuid_features()
> instead.
>
> And btw, those Intel QoS single bit defines and the XSAVE stuff there
> should move to that function too - that's a pure waste having them in
> the cap_flags array. I'll fix that.
>

Ok, I added it to init_scattered_cpuid_features() on top of your RFC
patch and it seems to work fine.

How do you prefer a V2 for this to be sent though-
Shall I wait until your fixes are in tip.git and resend?
Or send a V2 on top of current tip.git?

Thanks,
-Aravind.


\
 
 \ /
  Last update: 2015-10-27 00:21    [W:0.079 / U:1.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site