Messages in this thread | | | Subject | Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests | From | Robert Baldyga <> | Date | Mon, 26 Oct 2015 23:23:30 +0100 |
| |
On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: > This patch fixes a memory leak that occurs when an endpoint fails to enqueue > the request. If that happens the complete function will never be called, thus > never freeing the request. > > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> > --- > drivers/usb/gadget/function/f_midi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 4c01c8a..0e9cdeb 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -344,6 +344,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > if (err) { > ERROR(midi, "%s queue req: %d\n", > midi->out_ep->name, err); > + free_ep_req(midi->out_ep, req); > } > } > >
Don't we have similar problem in f_midi_transmit() and f_midi_complete() functions?
Best regards, Robert
| |