Messages in this thread | | | Subject | Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h | From | Laura Abbott <> | Date | Mon, 26 Oct 2015 14:41:23 -0700 |
| |
On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote: > Fixed checkpatch.pl warning about comment block coding style. >
The right aligned comments aren't great style. How about moving the comments (with the correct style) right above the macro they are describing.
> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com> > --- > drivers/staging/android/uapi/ion.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 68a14b4..11df59f 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -56,13 +56,15 @@ enum ion_heap_type { > * allocation flags - the lower 16 bits are used by core ion, the upper 16 > * bits are reserved for use by the heaps themselves. > */ > -#define ION_FLAG_CACHED 1 /* mappings of this buffer should be > - cached, ion will do cache > - maintenance when the buffer is > - mapped for dma */ > +#define ION_FLAG_CACHED 1 /* mappings of this buffer should be > + * cached, ion will do cache > + * maintenance when the buffer is > + * mapped for dma > + */ > #define ION_FLAG_CACHED_NEEDS_SYNC 2 /* mappings of this buffer will created > - at mmap time, if this is set > - caches must be managed manually */ > + * at mmap time, if this is set > + * caches must be managed manually > + */ > > /** > * DOC: Ion Userspace API >
| |