Messages in this thread | | | Date | Mon, 26 Oct 2015 18:45:42 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 03/52] perf tools: Add thread_map event |
| |
On Mon, Oct 26, 2015 at 02:42:06PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > PERF_RECORD_AUXTRACE_ERROR = 72, > > + PERF_RECORD_THREAD_MAP = 73, > > PERF_RECORD_HEADER_MAX > > }; > > > > @@ -356,6 +357,17 @@ struct context_switch_event { > > u32 next_prev_tid; > > }; > > > > +struct thread_map_data_event { > > Humm, I think "data" here is way too vague here, how about > "thread_map_event_entry"? > > Moving of "entry" to the end also helps in understanding that this is > not an "event" per se, it doesn't have the perv_event_header, etc, its > just an entry in a 'struct thread_map_event'. > > I'm tentatively doing this change in my local branch, please let me know > if you have any reason to object to such a change,
np, hope there's not much dependency on this later in patchset ;-) probably not..
thanks, jirka
| |