lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Since xfsaild has been converted to kthread in 0030807c, it calls
> try_to_freeze() during every AIL push iteration. It however doesn't set
> itself as freezable, and therefore this try_to_freeze() will never do
> anything.
>
> Before (hopefully eventually) kthread freezing gets converted to fileystem
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O
> during suspend).
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---

Looks fine to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> fs/xfs/xfs_trans_ail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
> long tout = 0; /* milliseconds */
>
> current->flags |= PF_MEMALLOC;
> + set_freezable();
>
> while (!kthread_should_stop()) {
> if (tout && tout <= 20)
> --
> Jiri Kosina
> SUSE Labs
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs


\
 
 \ /
  Last update: 2015-10-26 15:21    [W:0.128 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site