Messages in this thread | | | Date | Mon, 26 Oct 2015 14:41:38 +0100 | Subject | Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board | From | Linus Walleij <> |
| |
On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin <mcoquelin.stm32@gmail.com> wrote:
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> (...) > + leds { > + compatible = "gpio-leds"; > + red { > + gpios = <&gpiog 14 0>; > + }; > + green { > + gpios = <&gpiog 13 0>; > + };
I suggest you add labels to these LEDs.
label = "red-LED" label = "green-LED"
This make things so much easier in sysfs.
Usually people also want to add a default linux,trigger to these, like linux,default-trigger = "heartbeat"; but whatever you prefer.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |