Messages in this thread Patch in this message | | | From | Wang Nan <> | Subject | [RFC PATCH v2 2/2] perf tools: Don't set inherit bit for system wide evsel | Date | Mon, 26 Oct 2015 11:42:00 +0000 |
| |
Inherit bit is useless for a system wide evsel [1]. Further kernel improvements are giving more constrain [2] on inherit events. This patch set inherit bit to 0 for system wide evsels to avoid potential constrains.
[1] http://lkml.kernel.org/r/20151022124142.GQ17308@twins.programming.kicks-ass.net [2] http://lkml.kernel.org/r/1445559014-4667-1-git-send-email-ast@kernel.org
Signed-off-by: Wang Nan <wangnan0@huawei.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Alexei Starovoitov <ast@plumgrid.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Li Zefan <lizefan@huawei.com> Cc: pi3orama@163.com Link: http://lkml.kernel.org/n/ebpf-0xsuv8wc1uwgj7qfylfolgqs@git.kernel.org --- tools/perf/util/evsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 36ecf0e..2a5f0f8 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -736,7 +736,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) evsel->system_wide = opts->target.system_wide; attr->sample_id_all = perf_missing_features.sample_id_all ? 0 : 1; - attr->inherit = !opts->no_inherit; + attr->inherit = !opts->no_inherit && !evsel->system_wide; perf_evsel__set_sample_bit(evsel, IP); perf_evsel__set_sample_bit(evsel, TID); -- 1.8.3.4
| |