Messages in this thread | | | Date | Mon, 26 Oct 2015 10:02:13 +0100 | Subject | Re: [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST | From | Geert Uytterhoeven <> |
| |
On Sun, Oct 25, 2015 at 11:41 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > Commit 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is > enabled") allowed clk drives to be compile tested on other archs but > the COMMON_CLK_VERSATILE was only enabled on platforms that already > selected OF support so the drivers assume it will always be enabled. > > So, restrict compile test for these drivers only if OF is enabled. > > Fixes: 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is enabled") > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > drivers/clk/versatile/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index fc50b6264bed..e85863cf145f 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -1,6 +1,6 @@ > config COMMON_CLK_VERSATILE > bool "Clock driver for ARM Reference designs" > - depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST > + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || (COMPILE_TEST && OF)
I would separate the infrastructure and platform dependencies, like
depends on OF depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST
But it's of course up to the maintainer to decide.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |