Messages in this thread | | | Date | Thu, 22 Oct 2015 08:41:22 -0700 | Subject | Re: [PATCH 4/5] block: introduce file_bd_inode() | From | Dan Williams <> |
| |
On Thu, Oct 22, 2015 at 2:45 AM, Jan Kara <jack@suse.cz> wrote: > On Thu 22-10-15 02:42:05, Dan Williams wrote: >> Similar to the file_inode() helper, provide a helper to lookup the inode for a >> raw block device itself. > > So I somewhat dislike the name file_bd_inode() since for struct file > pointing to a regular file, the result would be equivalent to file_inode() > but the name suggests (at least to me) it should return block device inode. > I'd name it like bdev_file_inode() to make it clear this is local to > block device code...
I like it, will fix.
| |